Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't assume ucm trunk versions start with latest- #3234

Merged
merged 1 commit into from Jul 14, 2022

Conversation

aryairani
Copy link
Contributor

closes #3233

UCM versions are (intentionally) based on git describe and hence sensitive to the git repo state. When the welcome flow was written, trunk UCM builds tended to have a version number that began with latest-, but that won't necessarily be the case, and isn't the case today.

The result was that Main.launch was hitting this DontDownloadBase case instead of complaining about the unknown library:

let downloadBase = case defaultBaseLib of
Just remoteNS | shouldDownloadBase == ShouldDownloadBase -> Welcome.DownloadBase remoteNS
_ -> Welcome.DontDownloadBase

Controversial decisions

Maybe line 393 should be an error?

@aryairani aryairani merged commit d9970e9 into trunk Jul 14, 2022
@aryairani aryairani deleted the topic/always-fallback-to-base-main branch July 14, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VersionParser.defaultBaseLib shouldn't assume trunk builds start with latest-
2 participants