don't assume ucm trunk versions start with latest-
#3234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3233
UCM versions are (intentionally) based on
git describe
and hence sensitive to the git repo state. When the welcome flow was written,trunk
UCM builds tended to have a version number that began withlatest-
, but that won't necessarily be the case, and isn't the case today.The result was that
Main.launch
was hitting thisDontDownloadBase
case instead of complaining about the unknown library:unison/unison-cli/unison/Main.hs
Lines 391 to 393 in 265157b
Controversial decisions
Maybe line 393 should be an
error
?