feat: better suffixification in update and upgrade #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
off suffixifying definitions by hash when we can in upgrade
aryairani
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR continues the work of #4589 and #4605. Now (in
updateandupgrade), when rendering a collection of definitions, names that resolve to something in the namespace (not the file) will suffixify "by hash" (the familiar suffixify algorithm). It's only names that resolve to something in the file itself that are suffixified "by name" (which produces slightly worse names, but is necessary because aliases can share suffixes).Test coverage
See transcript updates for the gist of the user-facing changes.