Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we tag latest trunk for releases #4721

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Feb 27, 2024

If you don't have the latest trunk pulled to your local trunk ref then the release script will just tag whatever you have locally, now we pull to trunk first!

I didn't actually test it because it would make a release, so @aryairani maybe take it for a spin before merging :)

@ChrisPenner ChrisPenner marked this pull request as ready for review February 27, 2024 17:59
Copy link
Contributor

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed to work for me

@aryairani aryairani added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Feb 27, 2024
@mergify mergify bot merged commit 404a9f9 into trunk Feb 27, 2024
7 checks passed
@mergify mergify bot deleted the cp/fetch-in-release-script branch February 27, 2024 18:18
@mergify mergify bot removed the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants