New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try libb2-1 instead of libb2-dev #4901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mit :head_explode:
…ng in the build directory
…n the course of this pr, seems to work again
Some notes:
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched
libb2-dev
forlibb2-1
after Tweak crypto ffi for better dependencies #4900, to see if it would still build as well. Initially we couldn't tell because of a bug in the caching, which prevented a full build/test from being attempted.However, by switching the cache keys in 473c7b4 / https://github.com/unisonweb/unison/actions/runs/8841328469, we do see a
jit-binary-macOS-12
which includeslibb2.1.dylib
.Next, however, I refactored the CI workflow to try to fix the original caching bug, and the resulting builds no longer redistribute
libb2
.I wondered whether this was due to Tweak crypto ffi for better dependencies #4900 breaking something for macOS, but given (2), it doesn't seem possible. I wondered whether it was due to (1), but given (2), it doesn't seem to be that either. So I must have broken something in (3), but I don't know what yet.
Okay, it seems that the answer is that
libb2
needs to be installed beforeraco exe
; it's not enough for it to be installed beforeraco distribute
.And with (5),
libb2-1
with Tweak crypto ffi for better dependencies #4900 (1) is fine.