-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make pull
call new merge
instead of old merge
#4966
Conversation
we spookily rely on it! fragile! wow!
I merged bob into alice. | ||
I merged project/bob into project/alice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Could you fix up (or link a new ticket up to fix up) the error message, maybe just in the InputPattern
, so that if someone tries to pull @<x..> lib.<z>
, it will suggest lib.install @<x..>
instead.
Could you comment on the new help message that talks about "remote namespace" but "destination branch"; remind us why namespace in one case and branch in the other; is that purely a concession to Share loose code?
The PR description tells us the variation that no longer works, but could you remind us of the variations that do work, as of this PR? If it ends up only needing to be short then that's good enough; if it ends up being needing to be long, then maybe a manual transcript to demo the pull
command?
Sure.
Just that the source can be a project branch ("branch") or arbitrary path into loose code ("namespace"), but the target can only be a project branch ("branch").
This: " |
I updated the |
Overview
This PR makes
pull
perform a newmerge
instead of an oldmerge.old
.Implementation notes
pull
now has a more restricted type: you can only target a project branch. So, this syntax no longer worksthat people will be familiar with from our docs. So, we'll probably want to have a better error message than the current one, which just prints the
help pull
output.Test coverage
No new tests, but I tested the command manually