Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transcript that demonstrates bug in merge #5130

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mitchellwrosen
Copy link
Member

Overview

This PR adds a transcript that demonstrates #5125

Copy link
Contributor

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephrase/clarify that one line, otherwise good demo.


```

But `bar` was put into the scratch file instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of what; instead of being left out I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of being put into the underlying namespace (as mentioned above).

@mitchellwrosen mitchellwrosen merged commit eca0755 into trunk Jun 25, 2024
35 checks passed
@mitchellwrosen mitchellwrosen deleted the 24-06-25-merge-bug-transcript branch June 25, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants