Don't make a new lsp client for every workspace. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we merge this? I don't really have enough knowledge to review it, but I can be a rubber duck about it. |
|
This was an attempt to fix the issues that you were encountering specifically, but I'm not sure it solved those and am also not sure anyone else has encountered them 🤔 Maybe try it out? I believe you can just open this repo in vscode and hit F5 to test it. |
Cool thanks, I will try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the original extension I followed the multiple-workspaces example, but since you typically only have a single UCM session open, it doesn't make sense to have multiple LSP clients or servers, and it was leading to the unison lsp commands getting redundantly re-registered in VSCode and throwing errors.
I think this new version is simpler and should avoid those issues. If we really need separate workspaces again in the future I can figure out the proper way to do that, but it doesn't seem necessary right now.