Test whether an engine opened successfully

[achaloyan]

Originally reported on Google Code with ID 42

Hi Arsen,

I came across an issue related to engine-specific parameters you introduced
in r1079 -- many thanks. If a plugin needs some parameters from config, it
must be initialized in mrcp_engine_virtual_open(), not in
mrcp_plugin_create(). But the server does not care whether the
initialization was successful or not. You should check the return value in
mrcp_server.c:632.

Thanks.
- Vali

Reported by tomas.valenta@speechtech.cz on 2009-09-14 14:27:30

[achaloyan]

Hi Vali,
I completely agree, return value must be checked and I'll have closer look at this
issue hopefully soon.
Thanks,
Arsen.

Reported by achaloyan on 2009-09-14 16:37:43

• Status changed: Accepted
• Labels added: Type-Defect, Priority-Medium, OpSys-All, Component-Server, Component-Plugin

[achaloyan]

Hi Vali,
I addressed this issue in r1125, but seemed to forget update the status here.
Briefly, I added internal state to engine (is_open), which indicates whether engine
has been successfully opened or not. In any case engine remains in the table, but
will not be used if open method fails.

Reported by achaloyan on 2009-09-18 15:23:42

• Status changed: Fixed

[achaloyan]

Hi Arsen,
sorry for a little delay. Thank you for the patch, works as expected. Verified.
Cheers
- Vali

Reported by tomas.valenta@speechtech.cz on 2009-09-21 21:31:14

[achaloyan]

Thanks

Reported by achaloyan on 2009-10-05 16:29:12

• Status changed: Verified