Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ganache version to fix arbitrum test #311

Merged

Conversation

ytoast
Copy link
Contributor

@ytoast ytoast commented Jan 12, 2023

Arbitrum tests have been failing due to a Invalid transaction type: 106 error. More info.

This is fixed in the newer version of ganache.

@ytoast
Copy link
Contributor Author

ytoast commented Jan 12, 2023

Tests are failing due to failure to upload coverage report to Codecov (potentially missing the codecov repo upload token)

@ErikBjare
Copy link
Member

Nice, thanks!

Not sure why codecov suddenly fails, I guess it's a foreign-user PR issue? Merging anyway :)

@ErikBjare ErikBjare merged commit a2bd2a3 into uniswap-python:master Jan 12, 2023
@ytoast
Copy link
Contributor Author

ytoast commented Jan 13, 2023

thank you! :)

@ytoast
Copy link
Contributor Author

ytoast commented Jan 13, 2023

@ErikBjare Unfortunately it seems like the tests are still failing
https://github.com/uniswap-python/uniswap-python/actions/runs/3901172302

@ErikBjare
Copy link
Member

Seems like the tests are failing due to codecov/codecov-action#557 (comment)

I've set CODECOV_TOKEN in CI and hope that solves it.

@ytoast
Copy link
Contributor Author

ytoast commented Jan 17, 2023

perfect! works now! :)

@ytoast ytoast deleted the fix/github-workflow-arbitrum branch May 11, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants