Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update web3py to v6, apply no-implicit-optional, misc fixes #320

Merged
merged 13 commits into from
Mar 30, 2023
Merged

fix: update web3py to v6, apply no-implicit-optional, misc fixes #320

merged 13 commits into from
Mar 30, 2023

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Feb 24, 2023 •
edited

Fixes #322

@ErikBjare ErikBjare mentioned this pull request Feb 24, 2023
Open
@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited

Codecov Report

Patch coverage: 64.28% and project coverage change: -24.29 ⚠️

Comparison is base (da8c7dd) 84.35% compared to head (ece7f1e) 60.07%.

❗ Current head ece7f1e differs from pull request most recent head 1956fec. Consider uploading reports for the commit 1956fec to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #320       +/-   ##
===========================================
- Coverage   84.35%   60.07%   -24.29%     
===========================================
  Files          10       10               
  Lines        1042     1042               
===========================================
- Hits          879      626      -253     
- Misses        163      416      +253
Impacted Files Coverage Δ
uniswap/cli.py 92.95% <0.00%> (ø)
uniswap/tokens.py 64.28% <ø> (-21.43%) ⬇️
uniswap/uniswap.py 53.34% <57.14%> (-28.97%) ⬇️
uniswap/util.py 64.86% <100.00%> (-21.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErikBjare ErikBjare mentioned this pull request Mar 6, 2023
Closed
@ErikBjare ErikBjare mentioned this pull request Mar 28, 2023
Closed
@ErikBjare
Copy link
Member Author

ErikBjare commented Mar 29, 2023 •
edited

I'm stumped, I keep getting Revert reason: Not WETH9 for some reason :<

Also, why is CI not running?

ErikBjare
ErikBjare commented Mar 29, 2023
View reviewed changes
uniswap/uniswap.py Outdated Show resolved Hide resolved
ErikBjare
ErikBjare commented Mar 29, 2023
View reviewed changes
uniswap/uniswap.py Outdated Show resolved Hide resolved
@ErikBjare ErikBjare requested a review from liquid-8 March 29, 2023 16:42
@ErikBjare ErikBjare removed the request for review from liquid-8 March 30, 2023 13:10
@ErikBjare
Copy link
Member Author

Alright, finally done now.

Shipping :shipit:

@ErikBjare ErikBjare changed the title Misc fixes: update deps, apply no-implicit-optional, updated web3py names fix: update web3py to v6, apply no-implicit-optional, misc fixes Mar 30, 2023
@ErikBjare ErikBjare merged commit 6ff4539 into master Mar 30, 2023
6 checks passed
@ErikBjare ErikBjare mentioned this pull request Mar 30, 2023
Closed
@liquid-8
Copy link
Member

I couldn't manage to review it in time; sorry for that. I was going to take a look today. However, I'm glad it is fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error importing Uniswap with the latest version of web3.py
2 participants
@ErikBjare @liquid-8