fix: fix class empty issues

unit-mesh · Apr 17, 2023 · a9cf9be · a9cf9be
1 parent 7e64357
commit a9cf9be
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/src/main/kotlin/cc/unitmesh/devti/DevtiFlow.kt b/src/main/kotlin/cc/unitmesh/devti/DevtiFlow.kt
@@ -39,12 +39,11 @@ class DevtiFlow(
      */
     fun updateEndpointMethod(target: TargetEndpoint, storyDetail: String) {
         // 3. update endpoint method
-        val code = fetchCode(target.endpoint, target.controller, storyDetail)
         try {
+            val code = fetchCode(target.endpoint, target.controller, storyDetail)
             processor?.createControllerOrUpdateMethod(target.controller.name, code, target.hasMatchedController)
         } catch (e: Exception) {
-            logger.warn("update method failed: $e")
-            logger.warn("try to fill update method 2nd")
+            logger.warn("update method failed: $e, try to fill update method 2nd")
 
             val code = fetchCode(target.endpoint, target.controller, storyDetail)
             processor?.createControllerOrUpdateMethod(target.controller.name, code, target.hasMatchedController)

diff --git a/src/main/kotlin/cc/unitmesh/devti/analysis/DtAnalysisModel.kt b/src/main/kotlin/cc/unitmesh/devti/analysis/DtAnalysisModel.kt
@@ -26,11 +26,13 @@ class DtClass(
             output.append(")\n")
         }
 
-        output.append("- methods: ")
-        // filter out constructor
-        output.append(methods.filter { it.name != this.name }.joinToString(", ") { method ->
-            "${method.name}(${method.parameters.joinToString(", ") { parameter -> "${parameter.name}: ${parameter.type}" }}): ${method.returnType}"
-        })
+        if (methods.isNotEmpty()) {
+            output.append("- methods: ")
+            // filter out constructor
+            output.append(methods.filter { it.name != this.name }.joinToString(", ") { method ->
+                "${method.name}(${method.parameters.joinToString(", ") { parameter -> "${parameter.name}: ${parameter.type}" }}): ${method.returnType}"
+            })
+        }
 
         return output.toString()
     }

diff --git a/src/main/kotlin/cc/unitmesh/devti/analysis/JavaCrudProcessor.kt b/src/main/kotlin/cc/unitmesh/devti/analysis/JavaCrudProcessor.kt
@@ -98,7 +98,7 @@ class JavaCrudProcessor(val project: Project) : CrudProcessor {
     }
 
     override fun createControllerOrUpdateMethod(targetController: String, code: String, isControllerExist: Boolean) {
-        if (controllers.isEmpty()) {
+        if (!isControllerExist) {
             this.createController(targetController, code)
             return
         }

diff --git a/src/main/kotlin/cc/unitmesh/devti/runconfig/DtRunState.kt b/src/main/kotlin/cc/unitmesh/devti/runconfig/DtRunState.kt
@@ -2,6 +2,7 @@ package cc.unitmesh.devti.runconfig
 
 import cc.unitmesh.devti.DevtiBundle
 import cc.unitmesh.devti.DevtiFlow
+import cc.unitmesh.devti.analysis.DtClass
 import cc.unitmesh.devti.analysis.JavaCrudProcessor
 import cc.unitmesh.devti.kanban.impl.GitHubIssue
 import cc.unitmesh.devti.prompt.openai.OpenAIAction
@@ -50,6 +51,9 @@ class DtRunState(
 
                     indicator.text = DevtiBundle.message("devti.runconfig.progress.fetchingSuggestEndpoint")
                     val target = devtiFlow.fetchSuggestEndpoint(storyDetail)
+                    if (!target.hasMatchedController) {
+                        target.controller = DtClass(target.controller.name, emptyList())
+                    }
 
                     indicator.fraction = 0.6