process wrong response format #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iptton
commented
Mar 29, 2024
iptton
commented
- Introduce 'lastParseFailedResponse' to store the failed response.
- Log a detailed error message when a null response is encountered.
- Add a check at the end of the stream to notify the user if no successful parse occurred.
- Remove unnecessary 'hasSuccessRequest' toggle and related code. - Introduce 'lastParseFailedResponse' to store the failed response. - Log a detailed error message when a null response is encountered. - Add a check at the end of the stream to notify the user if no successful parse occurred.
- Remove unnecessary 'hasSuccessRequest' toggle and related code. - Introduce 'lastParseFailedResponse' to store the failed response. - Log a detailed error message when a null response is encountered. - Add a check at the end of the stream to notify the user if no successful parse occurred.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 12.19% 12.18% -0.01%
==========================================
Files 473 473
Lines 11023 11027 +4
Branches 2111 2111
==========================================
Hits 1344 1344
- Misses 9425 9429 +4
Partials 254 254 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.