Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seaborn import #1381

Closed
lucfra opened this issue Nov 24, 2022 · 4 comments
Closed

Seaborn import #1381

lucfra opened this issue Nov 24, 2022 · 4 comments
Labels
triage Issue waiting for triaging

Comments

@lucfra
Copy link

lucfra commented Nov 24, 2022

Dear authors,

first of all, congrats for the package! Really like it.

Secondarily, would be possible to make the seaborn package import optional?

Thanks!
Luca

@lucfra lucfra added the triage Issue waiting for triaging label Nov 24, 2022
@hrzn
Copy link
Contributor

hrzn commented Nov 30, 2022

Hi @lucfra and thanks for the feedback.
Where do you see seaborn imported? It's not a dependency of Darts, and should not be used anywhere in the code base. It might be a dependency of one of our dependencies, in which case I'd be happy if you provide me with a full stracktrace, so I can check whether this is something we could potentially remove.

@lucfra
Copy link
Author

lucfra commented Dec 6, 2022

Hi @hrzn ,

thanks! Here's a very minimal example of what I mean.
image

Not really sure how to print the stacktrace of an import statement.

Best wishes,
Luca

@hrzn
Copy link
Contributor

hrzn commented Dec 6, 2022

Oh, that's not due to seaborn, it's due to Darts currently redefining some of matplotlib's defaults.
You can disable this behavior setting the environment variable: DARTS_CONFIGURE_MATPLOTLIB=0.
See: #924
Hopefully that solves the issue.

@hrzn hrzn closed this as completed Dec 6, 2022
@lucfra
Copy link
Author

lucfra commented Dec 19, 2022

Ok thanks!
Would be nice to have the change of style as an opt-in feature probably.

Anyway, thanks again.

Cheers,
Luca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue waiting for triaging
Projects
None yet
Development

No branches or pull requests

2 participants