New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix - correct for multiple lengths of series in input sequence when adding static covariates to regression models #1469
Conversation
…ning-global-models-on-lists-of-timeseries
…-when-training-global-models-on-lists-of-timeseries' into 1460-bug-static-covariates-error-when-training-global-models-on-lists-of-timeseries
Codecov ReportBase: 93.95% // Head: 93.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
- Coverage 93.95% 93.91% -0.04%
==========================================
Files 122 122
Lines 10728 10728
==========================================
- Hits 10079 10075 -4
- Misses 649 653 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ning-global-models-on-lists-of-timeseries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just had a small comment about a variable name, and possibly adding one more test. Thanks for coming up with a (non-trivial) fix quickly @eliane-maalouf !
I made a modification to the function to control for the order of the static covariates, in case they change among the series in the input. I thought it would be easier to implement the control in code instead of asking the user to make sure a certain order is present in the static covariates. |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @eliane-maalouf
Fixes #1460
Summary
In the original version for the code adding static covariates to regression models, it was assumed that the series are of same length.
This PR corrects this assumption and allows to support cases where the series in the input sequence have different sizes.
Other Information
None