Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports_multivariate to ForecastingModel #1844

Closed
felixdivo opened this issue Jun 21, 2023 · 2 comments · Fixed by #1848
Closed

Add supports_multivariate to ForecastingModel #1844

felixdivo opened this issue Jun 21, 2023 · 2 comments · Fixed by #1848
Labels
feature request Use this label to request a new feature good first issue Good for newcomers
Projects

Comments

@felixdivo
Copy link
Contributor

felixdivo commented Jun 21, 2023

Is your feature request related to a current problem? Please describe.
It is dificult to determine whether a model supports multivariate time series or only univariate ones without building a dictionary of this.

Describe proposed solution
ForecastingModel gets a new attribute supports_multivariate. This is in line with supports_past_covariates etc...

Describe potential alternatives
Model via a superclass. But this would complicate things unnessesarily.

Additional context
This is cool if iterating over multiple models and evaluating their performance (semi-)automatically. This would allow to generate table contents similar to this when reporting on models behaviour (error, ...).

@felixdivo felixdivo added the triage Issue waiting for triaging label Jun 21, 2023
@madtoinou madtoinou added feature request Use this label to request a new feature and removed triage Issue waiting for triaging labels Jun 21, 2023
@madtoinou
Copy link
Collaborator

Hi @felixdivo,

Thank you for the suggestion! This is an very good suggestion, would you be willing to implement it?

You should be able to rely on the calls to ForecastingModel._assert_univariate() and ForecastingModel._assert_multivariate() in _fit() of models to know which one support what.

@madtoinou madtoinou added the good first issue Good for newcomers label Jun 21, 2023
@madtoinou madtoinou added this to To do in darts via automation Jun 21, 2023
@felixdivo
Copy link
Contributor Author

Jup, done in #1848.

@dennisbader dennisbader moved this from To do to In progress in darts Jun 26, 2023
darts automation moved this from In progress to Done Jul 5, 2023
@dennisbader dennisbader moved this from Done to Released in darts Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Use this label to request a new feature good first issue Good for newcomers
Projects
darts
Released
Development

Successfully merging a pull request may close this issue.

2 participants