Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] components name doesn't cover situation where multiple stat covariates contain the same category #1862

Closed
anne-devries opened this issue Jun 28, 2023 · 1 comment · Fixed by #1863
Assignees
Labels
improvement New feature or improvement
Projects

Comments

@anne-devries
Copy link
Contributor

anne-devries commented Jun 28, 2023

Describe the bug
Before the last release, when one-hot encoding static covariates, the resulting columns would be of the format <original_column_name><value1>, <original_column_name><value2>. But now, the resulting columns are just <value1>, <value2>. However, this causes problems when you have one category that is used by two (or more) static covariates. E.g. temperature could be low/medium/high, and sun_hours could be low/medium/high.

To Reproduce
Steps to reproduce the behavior, preferably code snippet.

Expected behavior
The previous method, where components get the original column name + the category value should be used again to make it more robust

Additional context
See gitter thread: https://matrix.to/#/!uumevxjBaNJhovFYgj:gitter.im/$k0hUoZmhTBemPnKZbMfYPim-Ejq5cfRR2YUIe_2QUcU?via=gitter.im&via=matrix.org&via=matrix.freyachat.eu

@anne-devries anne-devries added bug Something isn't working triage Issue waiting for triaging labels Jun 28, 2023
@anne-devries
Copy link
Contributor Author

@dennisbader @madtoinou I will start working on this ticket

@madtoinou madtoinou added improvement New feature or improvement and removed bug Something isn't working triage Issue waiting for triaging labels Jun 28, 2023
@madtoinou madtoinou added this to To do in darts via automation Jun 28, 2023
darts automation moved this from To do to Done Jun 28, 2023
@dennisbader dennisbader moved this from Done to Released in darts Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or improvement
Projects
darts
Released
Development

Successfully merging a pull request may close this issue.

2 participants