Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest pmdarima (1.7.1) requires statsmodels (>=0.11,<0.12) #194

Closed
norihitoishida opened this issue Sep 29, 2020 · 2 comments
Closed

Latest pmdarima (1.7.1) requires statsmodels (>=0.11,<0.12) #194

norihitoishida opened this issue Sep 29, 2020 · 2 comments
Labels
feature request Use this label to request a new feature

Comments

@norihitoishida
Copy link

Latest pmdarima (1.7.1) requires statsmodels>=0.11,<0.12(latest), because latest statsmodels seems to have bugs.

If users follow the official instructions for setting up Docker, they will end up with the latest statsmodels(0.12) installed.
So, should we fix requirements/main.txt like this?

- statsmodels>=0.11.1
+ statsmodels>=0.11.1, <0.12 

https://github.com/unit8co/darts/blob/master/requirements/main.txt

I would like to get your opinion. Thanks!

@norihitoishida norihitoishida added feature request Use this label to request a new feature triage Issue waiting for triaging labels Sep 29, 2020
@hrzn
Copy link
Contributor

hrzn commented Sep 29, 2020

Hi @norihitoishida , thanks for pointing this out! The next release should have statsmodels==0.11.1 (we are moving to == everywhere. In addition, we are also considering moving pmdarima to an optional extra dependency of Darts.

@norihitoishida
Copy link
Author

Hi @hrzn , thanks for your reply. Sounds good!

@LeoTafti LeoTafti removed the triage Issue waiting for triaging label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Use this label to request a new feature
Projects
None yet
Development

No branches or pull requests

3 participants