Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit and import fixing #36

Merged
merged 8 commits into from Feb 14, 2022
Merged

Pre-commit and import fixing #36

merged 8 commits into from Feb 14, 2022

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Nov 22, 2021

Followup after #35

jamt9000
jamt9000 reviewed Nov 25, 2021
View reviewed changes
detoxify/core.py Outdated Show resolved Hide resolved
@Borda
Copy link
Contributor Author

Borda commented Nov 25, 2021

I would suggest to install/add this GH bot, which make automatic fixes in active/open PRs
https://github.com/marketplace/pre-commit-ci

@Borda Borda marked this pull request as ready for review November 25, 2021 21:25
@Borda Borda requested a review from jamt9000 November 25, 2021 21:25
@Borda
Copy link
Contributor Author

Borda commented Nov 30, 2021

@laurahanu may I get your review also on this one? 🐰

laurahanu
laurahanu reviewed Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@laurahanu laurahanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, think this would be a good addition!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@Borda
Copy link
Contributor Author

Borda commented Dec 7, 2021

Looks good generally, think this would be a good addition!

Cool, just added your suggestion...
@laurahanu could you also enable this bot? https://github.com/marketplace/pre-commit-ci

@Borda
Copy link
Contributor Author

Borda commented Dec 13, 2021

@laurahanu any update here pls?

@Borda
Copy link
Contributor Author

Borda commented Dec 21, 2021

@jamt9000 @laurahanu any update here? 😕

@Borda Borda requested a review from laurahanu December 30, 2021 13:57
@Borda
Copy link
Contributor Author

Borda commented Jan 12, 2022

@jamt9000 @laurahanu pls ping 🐰 ^^

@Borda
Copy link
Contributor Author

Borda commented Jan 17, 2022

@jamt9000 @laurahanu Happy New Year 🎉

@Borda
Copy link
Contributor Author

Borda commented Jan 31, 2022

@jamt9000 @laurahanu mind checking the PR or shall I close it? 😕

@Borda
Copy link
Contributor Author

Borda commented Feb 14, 2022

@jamt9000 @laurahanu any update here? 😕

@jamt9000
Copy link
Collaborator

Sorry for the delay, looks good!

@jamt9000 jamt9000 merged commit 2813572 into unitaryai:master Feb 14, 2022
@Borda Borda deleted the pre-commit branch February 14, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamt9000 jamt9000 jamt9000 approved these changes

@laurahanu laurahanu Awaiting requested review from laurahanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Borda @jamt9000 @laurahanu