Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeze PL requirements #40

Merged
merged 1 commit into from Jan 14, 2022
Merged

freeze PL requirements #40

merged 1 commit into from Jan 14, 2022

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Jan 1, 2022

seems that Win does not like PL v1.5

@Borda
Copy link
Contributor Author

Borda commented Jan 1, 2022

@jamt9000 @laurahanu may I get your review on this fix? 🐰

@Borda Borda mentioned this pull request Jan 4, 2022
Merged
jamt9000
jamt9000 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@jamt9000 jamt9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a temp fix. Is it a known PL issue or should we be doing something different?

@Borda
Copy link
Contributor Author

Borda commented Jan 12, 2022

@jamt9000 @laurahanu could we merge it? 🐰

@laurahanu laurahanu merged commit 12f7c92 into unitaryai:master Jan 14, 2022
@Borda Borda deleted the freeze-req branch January 14, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamt9000 jamt9000 jamt9000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Borda @jamt9000 @laurahanu