New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit pytorch lightning version to prevent breaking changes #83

Merged

laurahanu merged 1 commit into unitaryai:master from dcferreira:dcferreira-patch-1

Jul 5, 2023

Contributor

dcferreira commented Apr 25, 2023

Pytorch lightning 2.0 has breaking changes that affect the training code.

If you setup a new environment with the current requirements, you'll get this error when running pytest:

FAILED tests/test_trainer.py::test_trainer - TypeError: __init__() got an unexpected keyword argument 'gpus'

This PR fixes that by limiting pytorch lightning's version to be below 2.0.


          limit pytorch lightning version to prevent breaking changes

e94628b

laurahanu merged commit 1a1b31e into unitaryai:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment