Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform from modal #850

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aaron-Robertson
Copy link
Contributor

Fixes #708

@Aaron-Robertson
Copy link
Contributor Author

@WrathfulSpatula @vprusso Is the edit button what we have in mind here? I haven't gotten a chance to test yet, but I wonder if a typeahead add new option might be nicer, since we're already in a modal.

@WrathfulSpatula
Copy link
Collaborator

@Aaron-Robertson I suspect that we need to open a secondary SubmissionRefsAddModal. Then, when the user creates the platform in that modal, it'll be necessary to automatically add the reference to the current submission, or it won't be possible to key a result to it. (I actually think Will's suggestion in #708 breaks separation of concerns pretty badly, but we decided to bounty the issue, so that's what has to be done: the user opens a new modal, defines the platform, and the front end automatically adds it as a reference to the current submission. Actually, SubmissionRefsAddModal might already add the reference to the current submission.)

@Aaron-Robertson
Copy link
Contributor Author

Gotcha, modal in modal it is! Do we want to include a dropdown option that says "Add Platform"? Or use the existing EditButton on the "Platform" label?

@WrathfulSpatula
Copy link
Collaborator

Users can either add an existing platform or create a new one, from here. So long as both options are available, I trust you to decide on "look-and-feel," whether using EditButton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to create a new platform from the add result modal
2 participants