Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for measurement gates in Cirq folding functions #22

Closed
rmlarose opened this issue Feb 28, 2020 · 3 comments
Closed

Check for measurement gates in Cirq folding functions #22

rmlarose opened this issue Feb 28, 2020 · 3 comments
Assignees

Comments

@rmlarose
Copy link
Contributor

Folding functions should ignore measurement gates and continue to try to fold other gates. No unit tests currently check circuits with measurements in them.

@andreamari
Copy link
Member

We should think how to do the global unitary_folding in the case in which we have measurements in the middle of the circuit (final measurements can be removed and re-appended after folding). Maybe, in this case of intermediate measurements, global folding is just impossible and we should only raise an error.

@rmlarose
Copy link
Contributor Author

rmlarose commented Mar 5, 2020

Will and I briefly discussed the possibility of new theory for folding circuits with intermediate measurements, but for now I think raising an error is the right thing to do. (And to ignore terminal measurements while folding.)

@willzeng
Copy link
Contributor

I believe this was closed by #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants