-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QMaskFusion
#874
Merged
Merged
QMaskFusion
#874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying benchmarks quickly, before merging, but I'm probably not going to be too unpleasantly surprised. |
This is still unstable, in the benchmark suite. |
The remaining bug was in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new gate fusion layer, which will typically sit as a layer just above
QPager
orQEngine
. The inspiration was this paper, "Faster Schrödinger-style simulation of quantum circuits":https://arxiv.org/abs/2008.00216
To paraphrase, one of the optimizations emphasized in that paper is making sure to pad gates with as few identity operations as possible, to avoid redundant traversals of the state vector. To this end, we add
XMask()
,YMask()
, andZMask()
, which can efficiently apply multiple Pauli gates at once on different qubit indices, with a single state vector traversal. To take full advantage of this optimization, particularly in the default "optimal" layer stack, we insert theQMaskFusion
layer at the appropriate level of the stack, to coalesce and fuse Pauli operators.This does not cover multi-qubit-gate-fusion, yet, except for parallel Pauli operations. Another fusion layer, potentially closer in design to the original
QFusion
, might sit aboveQUnit
, ultimately.