Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

57: Added definition for s (second) as per 9th Draft SI Brochure #168

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

teobais
Copy link
Member

@teobais teobais commented Jan 26, 2019

The way the equations are herewith represented is something I personally don't like that much (we're not in Latex unfortunately 😂 ), but I would be interested in the views of the rest as well.


This change is Reviewable

@desruisseaux
Copy link
Contributor

I would suggest to add some sentence saying that the definition of second in this javadoc is only informative. The normative part of JSR-385 specification could be the requirement to use SI definition (if we want to put that requirement - Werner, is it the case?). Then we can reproduce that definition in the comment for information purpose, but in case of doubt, typo or update from SI, the definition published by SI is normative. It could be just adding a sentence like: "This quantity is measured by a unit defined by SI as below (informative):". If the definition is copied from SI verbatim, then I suggest to put it in a HTML <blockquote> element, or any other way showing that we are quoting.

@keilw
Copy link
Member

keilw commented Jan 26, 2019

Where possible we should use the (new) SI definition.

@teobais
Copy link
Member Author

teobais commented Jan 26, 2019

So, we leave it as is (?) or am I missing something?

@desruisseaux
Copy link
Contributor

I'm neutral on whether we leave it as is or not. My point was that if we want JSR-385 to be aligned on latest SI definition, then the javadoc should point to the SI definition and make clear that the copied text is only informative (i.e. that users should check the SI web site for most up-to-date definition).

@teobais
Copy link
Member Author

teobais commented Jan 27, 2019

Good point @desruisseaux .
However, in order to avoid commits that might need to be changed before merging this, I would suggest that @keilw provides us with a specific direction.

@keilw keilw merged commit 9791193 into unitsofmeasurement:master Jan 27, 2019
@keilw keilw removed the in progress label Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants