161: Fix JUnit 5 and Surefire issues. #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surefire from version 2.22.0 brings its own JUnit 5 platform provider.
The previous setup was incomplete and missed the engine as dependency of
surefire.
Your test coverage was zero as no test has been run.
The fix was easy: Just use at least surefire 2.22.1 (will work on JDK
11, too) and remove all the manual declaration of JUnit 5 platform,
launcher and runner.
In addition I'd recommend here to get rid of JUnit 4 as well, so nobody
adds an old JUnit 4 test by coincidence.
Also bump JUnit to the most recent version.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)