Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Optional base atom for Event Instancers #170

Closed
mutmedia opened this issue Jun 29, 2020 · 3 comments
Closed

[FEATURE] Optional base atom for Event Instancers #170

mutmedia opened this issue Jun 29, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers ready to be developed This issue is ready to be developed

Comments

@mutmedia
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It's frustrating having to create/choose a base AtomEvent whenever using an EventInstancer, especially since most of the cases they are the same.

Describe the solution you'd like
I'd like to be able to not add any base events and it still work (I understand the rare usecase for base events)

Describe alternatives you've considered
The solutions I thought of were either removing the base event entirely, or making a null check and instantiating a new event of the required type at runtime

@mutmedia mutmedia added the enhancement New feature or request label Jun 29, 2020
@AdamRamberg
Copy link
Collaborator

Thanks for this issue! This sounds good to me. Just use CreateInstance if _base is null. The one doing this change will also need to remove the assert on OnEnable. I will label this issue "ready to be developed", so whoever feels motivated could grab it and start develop it

@AdamRamberg AdamRamberg added good first issue Good for newcomers ready to be developed This issue is ready to be developed labels Jun 30, 2020
@mutmedia
Copy link
Contributor Author

mutmedia commented Jul 1, 2020

There's a PR out for this (and #171)

@AdamRamberg
Copy link
Collaborator

Closed by #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ready to be developed This issue is ready to be developed
Projects
None yet
Development

No branches or pull requests

2 participants