Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not usable: it creates holes alongside UV boundaries #6

Closed
laurentopia opened this issue Feb 15, 2018 · 19 comments
Closed

not usable: it creates holes alongside UV boundaries #6

laurentopia opened this issue Feb 15, 2018 · 19 comments
Labels
enhancement New feature or request that is slated for development

Comments

@laurentopia
Copy link

https://i.imgur.com/rm35rUm.png

@amirebrahimi
Copy link
Contributor

What simplifier are you using?

@laurentopia
Copy link
Author

Quadric

@amirebrahimi
Copy link
Contributor

Yes, simulated is just that - a simulation of what gains you could expect, but essentially much quicker at generating. It might need a rename to FakeSimplifier perhaps to be more clear.

Re: the Quadric, that is from this GitHub project: https://github.com/Whinarn/UnityMeshSimplifier. You could post an issue there, but that simplifier is based on https://github.com/sp4cerat/Fast-Quadric-Mesh-Simplification, which might be where the actual problem lies.

If you have Simplygon or InstaLOD you may see better results.

The AutoLOD framework is built in such a way that any mesh simplifier could easily plug into the system.

@laurentopia
Copy link
Author

which version of simpligon needs to be installed?

@amirebrahimi
Copy link
Contributor

8.2.X, but unfortunately they pulled their existing Unity plugin and still have not published a new one. I pointed this out on their forum and have not heard a response back. The old plugin worked fine in my tests.

If you're registered on their forums, this is the post: https://simplygon.freshdesk.com/support/discussions/topics/5000086159

@laurentopia
Copy link
Author

I saw that only ue has an installer, is the old plugin available somewhere?

@amirebrahimi
Copy link
Contributor

Not that I can see. If you happen to find another good simplifier that works well for your model, I'd be willing to write implement an ISimplifier wrapper for it, similar to the other simplifiers.

@laurentopia
Copy link
Author

This one is ok https://github.com/wjakob/instant-meshes

@amirebrahimi
Copy link
Contributor

amirebrahimi commented Feb 15, 2018

This was suggested in #2, but it looks like there are some concerns about how well it would work for simplification. I haven't looked into it further. Have you tried it with your model to generate LODs?

@laurentopia
Copy link
Author

Yes I have used it, it's quite good at simplification as it keeps the flow of the mesh but it doesn't transfer UVs...

@laurentopia
Copy link
Author

oh, did you see that? you need to set a flag to keep the borders Whinarn/UnityMeshSimplifier#2

@amirebrahimi
Copy link
Contributor

amirebrahimi commented Feb 15, 2018

Yes, I was aware of this. When I talked with @Whinarn it seemed like better results were reached with the preserve borders flag turned off, but I've added an issue #7 into defaulting this to true perhaps and/or providing a way for custom options to be set on a selected simplifier.

Re: instant-meshes, it's great to hear that it does a good job for simplification for you, but without transferring UVs I see that as a big miss for attempting to integrate into AutoLOD. Don't you agree?

@Whinarn
Copy link

Whinarn commented Feb 16, 2018

The reason preserving borders was turned off by default was that it restricted the simplification, and mostly only worked on high poly meshes. But only to a certain polygon count since the border edges are never removed. So while it makes sure that holes doesn't get created, it ends up being bad at the actual mesh simplification in many cases. So I would personally think that providing options would be a better idea instead of defaulting it.

@laurentopia
Copy link
Author

laurentopia commented Mar 12, 2018

@Whinarn improved the quadratic decimation algorithm. See if the WIP branch works for you, I dropped it in and it auto generates empty mesh so I think you need to set things up differently.
Whinarn/UnityMeshSimplifier#2 (comment)
https://github.com/Whinarn/UnityMeshSimplifier/tree/feature-prevent-holes

@Whinarn
Copy link

Whinarn commented Mar 13, 2018

Oh I don't recommend that they use it just yet, since it's a work in progress. I only meant to show my current progress if you were interested in trying it out yourself. Sorry if I didn't make that clear.

I'm trying to finish it up when I have some time over, but I want to make sure that it works a lot better before I suggest that people start using it.

@laurentopia
Copy link
Author

Oh ok.

@Whinarn
Copy link

Whinarn commented Apr 1, 2018

I have created a new vertex linking feature that improves the decimation results a lot with all the meshes I have for testing. There are still some artifacts that can be improved, but it is a huge improvement by itself.
More details about the update can be found here: Whinarn/UnityMeshSimplifier@80e5bb0

@amirebrahimi you might be interested in looking at the latest updates for https://github.com/Unity-Technologies/UnityMeshSimplifier

@laurentopia
Copy link
Author

Thank you Whinarn, I will try it as soon as it's in AutoLOD.

@amirebrahimi
Copy link
Contributor

Updated to latest with ed3c61f

@amirebrahimi amirebrahimi added the enhancement New feature or request that is slated for development label Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request that is slated for development
Projects
None yet
Development

No branches or pull requests

3 participants