Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the speed of reading onnx file gets slower by updating from 0.4 to 0.6. #24

Closed
h-nakae opened this issue Feb 27, 2020 · 8 comments
Closed
Assignees

Comments

@h-nakae
Copy link

h-nakae commented Feb 27, 2020

Hi,
Firstly,We really appreciate for you've done.
Thanks to your product, we could build our results↓
https://github.com/digital-standard/ThreeDPoseUnityBarracuda

And there is a question this time.
We are using version 0.4 of Barracuda to read onnx file and move 3D avatar in unity and it goes well.
But the speed gets slower by updating the version to 0.6.

Do you know the reason or solution of this?
It is very kind of you, if you could tell me that.

Thank you for your help.
Hiro

@FlorentGuinier
Copy link

Hi h-nakae, Barracuda 0.6.1 was just published. Along with it a performance regression was fixed. Could you give it a try please?

@h-nakae
Copy link
Author

h-nakae commented Mar 4, 2020

Hi FlorentGuinier ,
Thank you for your replying.
I have just tried the new version, but it seems that the speed is still slow unfortunately...

Here, I put the screen shot.
The left one is version0.4, the second is 0.6.
The speed is as follwing.

v0.4 ⇒ 29.0 FPS
v0.61 ⇒ 15.7FPS

barracuda_compare

Thank you for your helping.

@yukihiko
Copy link

yukihiko commented Mar 5, 2020

Hi,
In the model I am using, the model layer was 145 layers in Ver0.4, 405 layers in Ver0.6.1, and there was a difference after loading the onnx model.
The layer added in Ver0.6.1. was of Type.Load.
This may be one of the reasons.
I do not understand what the data of Type.Load, but I tried put this code at the top of the loop in the ExecuteAsync method in GenericWorker.cs

if (l.type == Layer.Type.Load) continue;

The processing was improved from 23fps to 43fps.
(It is about 55fps in ver0.4)
At Type.Load, I don't know if PrepareStorage method is not needed.

@mantasp mantasp self-assigned this Mar 16, 2020
@mantasp
Copy link
Contributor

mantasp commented Mar 16, 2020

@yukihiko we managed to reproduce issue, we expect to ship fix in 0.6.2.
Thanks for reporting!

@yukihiko
Copy link

Thank you! I'm hoping for the next release.

@mantasp
Copy link
Contributor

mantasp commented Mar 23, 2020

@yukihiko we just shipped 0.6.2, could you please check if your use case performance is back?

@yukihiko
Copy link

I tried ver.0.6.2.
It's a great job!
It became almost the same speed as ver.0.4.(I think ver.0.4 is about 1fps faster)
Thank you!

@h-nakae
Copy link
Author

h-nakae commented Mar 25, 2020

@mantasp , @FlorentGuinier

Thank you for the updating.
That is nice of you.

I'm satisfied with that so I will close this issue.
Thanks

@h-nakae h-nakae closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants