-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removes most of physics2D implement custom solution #5280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bod9001
changed the title
this physics is to remove most of physics2D
removes most of physics2D implement custom solution
Oct 11, 2020
github-actions
bot
added
Status: Merge Conflicts
No one likes conflicts, solve them!
Scene Changes
Any changes that affect scenes (e.g. lobby or maps)
Scene: FallStation
This PR makes changes on FallStation map
UI
labels
Oct 11, 2020
github-actions
bot
added
Scene: BoxStation
This PR makes changes on BoxStation map
Scene: OutpostStation
This PR makes changes on OutpostStation map
Scene: PogStation
This PR makes changes on PogStation map
Scene: SquareStation
This PR makes changes on SquareStation map
labels
Oct 12, 2020
I will comment the ones I think are real concerns |
Here is an overview of what got changed by this pull request: Issues
======
+ Solved 7
- Added 5
Complexity increasing per file
==============================
- UnityProject/Assets/Scripts/Tilemaps/Behaviours/Layers/MetaTileMap.cs 3
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileStun.cs 1
- UnityProject/Assets/Scripts/Managers/MatrixManager/MatrixManager.cs 3
- UnityProject/Assets/Scripts/Tilemaps/Behaviours/Layers/TileLocation.cs 2
- UnityProject/Assets/Scripts/NPC/AI/Hostile/StatueAI.cs 1
- UnityProject/Assets/Scripts/NPC/AI/MobMeleeAction.cs 1
- UnityProject/Assets/Scripts/Tilemaps/Behaviours/Layers/Layer.cs 2
- UnityProject/Assets/Scripts/Managers/MatrixManager/MatrixManager.Collisions.cs 1
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageLivingHealthKinetic.cs 1
- UnityProject/Assets/Scripts/Tilemaps/Utils/Types.cs 1
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageLivingHealth.cs 1
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageIntegrity.cs 1
Complexity decreasing per file
==============================
+ UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageAtPoint.cs -1
Clones removed
==============
+ UnityProject/Assets/Scripts/NPC/AI/Hostile/GenericHostileAI.cs -1
+ UnityProject/Assets/Scripts/NPC/AI/Hostile/FaceHuggerAI.cs -1
See the complete overview on Codacy |
Bod9001
commented
Oct 16, 2020
Bod9001
commented
Oct 16, 2020
Bod9001
commented
Oct 16, 2020
Bod9001
commented
Oct 16, 2020
Bod9001
commented
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Scene: BoxStation
This PR makes changes on BoxStation map
Scene Changes
Any changes that affect scenes (e.g. lobby or maps)
Scene: FallStation
This PR makes changes on FallStation map
Scene: OutpostStation
This PR makes changes on OutpostStation map
Scene: PogStation
This PR makes changes on PogStation map
Scene: SquareStation
This PR makes changes on SquareStation map
Sprite Work
UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still needs to be worked on a bit
for example removing from scenes
Changelog
CL: ordered log levels to be alphabetical
CL: moved tile get set out of unity functions to allow it to be thread safe, this opens up the possibility of radiation being more dynamic
CL: removed tile map Colliders, replace it with a custom solution
CL: removed tables from objects, now on their own layer