Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes most of physics2D implement custom solution #5280

Merged
merged 7 commits into from
Oct 16, 2020
Merged

removes most of physics2D implement custom solution #5280

merged 7 commits into from
Oct 16, 2020

Conversation

Bod9001
Copy link
Member

@Bod9001 Bod9001 commented Oct 11, 2020

still needs to be worked on a bit
for example removing from scenes

Changelog

CL: ordered log levels to be alphabetical
CL: moved tile get set out of unity functions to allow it to be thread safe, this opens up the possibility of radiation being more dynamic
CL: removed tile map Colliders, replace it with a custom solution
CL: removed tables from objects, now on their own layer

@Bod9001 Bod9001 changed the title this physics is to remove most of physics2D removes most of physics2D implement custom solution Oct 11, 2020
@github-actions github-actions bot added Status: Merge Conflicts No one likes conflicts, solve them! Scene Changes Any changes that affect scenes (e.g. lobby or maps) Scene: FallStation This PR makes changes on FallStation map UI labels Oct 11, 2020
@github-actions github-actions bot added Scene: BoxStation This PR makes changes on BoxStation map Scene: OutpostStation This PR makes changes on OutpostStation map Scene: PogStation This PR makes changes on PogStation map Scene: SquareStation This PR makes changes on SquareStation map labels Oct 12, 2020
@unitystation unitystation deleted a comment from corp-0 Oct 12, 2020
@unitystation unitystation deleted a comment from corp-0 Oct 12, 2020
@unitystation unitystation deleted a comment from corp-0 Oct 12, 2020
@corp-0
Copy link
Member

corp-0 commented Oct 14, 2020

I will comment the ones I think are real concerns

@unitystation unitystation deleted a comment from corp-0 Oct 14, 2020
@unitystation unitystation deleted a comment from corp-0 Oct 14, 2020
@unitystation unitystation deleted a comment from corp-0 Oct 14, 2020
@Bod9001 Bod9001 removed the Status: Merge Conflicts No one likes conflicts, solve them! label Oct 16, 2020
Copy link
Member Author

Bod9001 commented Oct 16, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 7
- Added 5
           

Complexity increasing per file
==============================
- UnityProject/Assets/Scripts/Tilemaps/Behaviours/Layers/MetaTileMap.cs  3
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileStun.cs  1
- UnityProject/Assets/Scripts/Managers/MatrixManager/MatrixManager.cs  3
- UnityProject/Assets/Scripts/Tilemaps/Behaviours/Layers/TileLocation.cs  2
- UnityProject/Assets/Scripts/NPC/AI/Hostile/StatueAI.cs  1
- UnityProject/Assets/Scripts/NPC/AI/MobMeleeAction.cs  1
- UnityProject/Assets/Scripts/Tilemaps/Behaviours/Layers/Layer.cs  2
- UnityProject/Assets/Scripts/Managers/MatrixManager/MatrixManager.Collisions.cs  1
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageLivingHealthKinetic.cs  1
- UnityProject/Assets/Scripts/Tilemaps/Utils/Types.cs  1
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageLivingHealth.cs  1
- UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageIntegrity.cs  1
         

Complexity decreasing per file
==============================
+ UnityProject/Assets/Scripts/Items/Weapons/Projectiles/Behaviours/ProjectileDamageAtPoint.cs  -1
         

Clones removed
==============
+ UnityProject/Assets/Scripts/NPC/AI/Hostile/GenericHostileAI.cs  -1
+ UnityProject/Assets/Scripts/NPC/AI/Hostile/FaceHuggerAI.cs  -1
         

See the complete overview on Codacy

@Bod9001 Bod9001 merged commit e6de9b4 into unitystation:develop Oct 16, 2020
@Bod9001 Bod9001 deleted the Physics-rebased branch October 18, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scene: BoxStation This PR makes changes on BoxStation map Scene Changes Any changes that affect scenes (e.g. lobby or maps) Scene: FallStation This PR makes changes on FallStation map Scene: OutpostStation This PR makes changes on OutpostStation map Scene: PogStation This PR makes changes on PogStation map Scene: SquareStation This PR makes changes on SquareStation map Sprite Work UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants