Blob fixes #5372
Merged
Blob fixes #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoooneyDude
reviewed
Oct 21, 2020
UnityProject/Assets/Scripts/Core/Sprite Handler/SpriteHandlerManager.cs
Outdated
Show resolved
Hide resolved
ThatDan123
added
the
Status: Awaiting Review
|
how would you feel about doing the check for amount of tiles using events instead of the periodic update? |
|
All good for review. |
Bod9001
reviewed
Oct 21, 2020
Bod9001
reviewed
Oct 21, 2020
|
I've renamed the IsBlob to IsPlayerSemiGhost, tbh I think its only going to be used by blobs and AI, cant think of any other stuff which would require no real body. |
|
Issues
======
+ Solved 4
Complexity increasing per file
==============================
- UnityProject/Assets/Scripts/Managers/LavaLandManager.cs 2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed sound, fixes syncvars, fixed blob tile death counting
CL: Fixed blobs rejoining having wrong UI
CL: Fixed blob sound being global
CL: Fixed multiple blob sharing the UI updates
CL: Fixed Blob tile count not decreasing when blob tiles are killed
CL: Prohibited blobs from constructing node, factory and resources blobs on normal space blob tiles
CL: Stopped blob attack messages from auto expand
CL: Fixed blob attack effect not being played on client
CL: Fixed blob aghost