-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes disposal bin, DirectionalPassable, Disposal intake, pushing in editor #5373
Conversation
If you do update doors to use this component, remember to update the new doors instead |
But what if I just want to do nothing, |
change the name of the pr 👀 |
if you ever get to the default, then something went wrong with the values because you don't really wanted to get to that clause. You can log.error it so we know for some reason the switch didn't get the values we were expecting. For that reason having a default clause is a sensible decision. |
just need to add the log statement will merge after that |
Here is an overview of what got changed by this pull request: Issues
======
+ Solved 1
Complexity increasing per file
==============================
- UnityProject/Assets/Scripts/Objects/Directionals/DirectionalPassable.cs 1
Clones removed
==============
+ UnityProject/Assets/Scripts/Objects/PushPull.cs -2
See the complete overview on Codacy |
is all good to merge now? |
Yes good to merge! |
DirectionalPassable
component.DirectionalPassable
instead ofRegisterDoor
.CL:Fixes being unable to dispose of yourself, and unable to drag disposal intakes.