Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes disposal bin, DirectionalPassable, Disposal intake, pushing in editor #5373

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

NoooneyDude
Copy link
Contributor

@NoooneyDude NoooneyDude commented Oct 21, 2020

  • Fixes being unable to drag things into the disposal bin.
  • Fixes DirectionalPassable component.
  • Swaps directional windows to use DirectionalPassable instead of RegisterDoor.
  • Fixes pushing while playing in editor being buggy.

Note: it is now possible to convert directional doors to use DirectionalPassable, too.

CL:Fixes being unable to dispose of yourself, and unable to drag disposal intakes.

@corp-0
Copy link
Member

corp-0 commented Oct 21, 2020

If you do update doors to use this component, remember to update the new doors instead

@NoooneyDude
Copy link
Contributor Author

NoooneyDude commented Oct 21, 2020

Codacy: remove the empty default clause.
Codacy: add a default clause.

But what if I just want to do nothing, Codacy?

@corp-0
Copy link
Member

corp-0 commented Oct 21, 2020

change the name of the pr 👀

@NoooneyDude NoooneyDude changed the title Fixes Fixes disposal bin, DirectionalPassable, Disposal intake, pushing in editor Oct 21, 2020
@corp-0
Copy link
Member

corp-0 commented Oct 21, 2020

Codacy: remove the empty default clause.
Codacy: add a default clause.

if you ever get to the default, then something went wrong with the values because you don't really wanted to get to that clause. You can log.error it so we know for some reason the switch didn't get the values we were expecting. For that reason having a default clause is a sensible decision.

@Bod9001
Copy link
Member

Bod9001 commented Oct 21, 2020

just need to add the log statement will merge after that

Copy link
Member

Bod9001 commented Oct 22, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

Complexity increasing per file
==============================
- UnityProject/Assets/Scripts/Objects/Directionals/DirectionalPassable.cs  1
         

Clones removed
==============
+ UnityProject/Assets/Scripts/Objects/PushPull.cs  -2
         

See the complete overview on Codacy

@Bod9001
Copy link
Member

Bod9001 commented Oct 22, 2020

is all good to merge now?

@NoooneyDude
Copy link
Contributor Author

Yes good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants