Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the wizard's lightning bolt spell, and the magic mirror #5561

Merged
merged 5 commits into from
Nov 8, 2020

Conversation

NoooneyDude
Copy link
Contributor

@NoooneyDude NoooneyDude commented Nov 8, 2020

  • Adds the electrical arc effect. Uses LightningBolt asset.
  • Adds the lightning bolt spell. Continues First Implementation of the Wizard Antagonist B : 100 #5160.
    lightning bolt
  • The wizard now spawns with a random name.
  • Adds the magic mirror. Enables the wizard to change their name.
    • Includes wizard scene changes to reflect the addition.
  • Paper can now fit in the ID slot.
  • Wizards now spawn with an identity certificate instead of a station ID card.
  • The Wizard 101 paper that spawns in the pocket is now populated.
  • Paper item now uses TextMeshPro instead of default Unity Text. Fixes Change Paper Text box to TMP #4613

CL:Added lightning bolt spell and the magic mirror.

@github-actions github-actions bot added Scene Changes Any changes that affect scenes (e.g. lobby or maps) UI labels Nov 8, 2020
@corp-0
Copy link
Member

corp-0 commented Nov 8, 2020

Codacy is complaining but it has a point. Unity uses IEnumerators in a hacky way to make code run "asynchronically". In this case we can ignore the complain.

@Ruzihm
Copy link
Contributor

Ruzihm commented Nov 8, 2020

@corp-0 Nothing is calling StartCoroutine on MobSprite.StopElectrocutedOverlayAfter, and nothing is yield returning with it so codacy is right. it doesn't need to return IEnumerator because is is never used as a coroutine.

Contrast with PlayerSprites.StopElectrocutedOverlayAfter, which does get called as a coroutine.

I'm guessing it is meant to be called with StartCoroutine in this case.

@NoooneyDude
Copy link
Contributor Author

Ah. Good catch! I'll commit a fix.

Co-authored-by: Richard Van Tassel <Ruzihm@users.noreply.github.com>
@corp-0
Copy link
Member

corp-0 commented Nov 8, 2020

my bad. I thought it was complaining because the return value was never used, but it was actually the whole thing never being called. Hooray for codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scene Changes Any changes that affect scenes (e.g. lobby or maps) UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Paper Text box to TMP
4 participants