Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Contract of Apprenticeship #5700

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

NoooneyDude
Copy link
Contributor

@NoooneyDude NoooneyDude commented Dec 3, 2020

Note:

  • not tested on headless; seems to be a develop issue.
  • artifact refunding is not currently implemented.

CL:Added Contract of Apprenticeship.

@github-actions github-actions bot added the UI label Dec 3, 2020
@NoooneyDude
Copy link
Contributor Author

NoooneyDude commented Dec 3, 2020

Regarding the Codacy warnings:

  • ContractOfApprenticeship.OnGhostRoleTimeout event is actually invoked; see line 64 of the same file - you can see it working as intended in the gif.
  • The float comparison warnings can be ignored as we're setting a specific integer value for two specific cases; this value was not derived from maths with float.

@Bod9001 Bod9001 merged commit c2e5a91 into unitystation:develop Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants