switch suppressors to use slots #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests just complain about the template scenes, which will be removed in 5705 anyways. |
…into slotbasedsuppressor
|
the octagon of doom is the wrong interaction when clicking the adjacent tile and hitting yourself? |
|
it happens with guns, lowering the magnitude means the check is only done when your target is on the same tile |
|
how did you get to 0.5 as the right number? |
|
half a tile from the players position (the center of a tile) , as apposed to 1.1, which is a tile and a bit |
|
alrighty then, thanks. Can you mention that fix for the changelog? It is an important one some players will be happy to read it is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aint much too it
CL: fixed the radius around the player that caused them to accidentally attack themselves