Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RockDrop spell #5766

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Adds RockDrop spell #5766

merged 2 commits into from
Dec 22, 2020

Conversation

NoooneyDude
Copy link
Contributor

@NoooneyDude NoooneyDude commented Dec 20, 2020

  • Adds a new wizard spell, Rockdrop. The final spell for First Implementation of the Wizard Antagonist B : 100 #5160.
    balderdash
  • Converts Lesser Summon Guns to use new portal spawning method.
    • Should fix issue of portal and gun animations not working on clients.
  • New component RandomInitialSprite. Simply sets the SpriteHandler to use a random SO from the list at initialisation.

CL:Added RockDrop spell.

Note

Sprites are not final.
There is no sound for the spell yet.

/// <summary>
/// Initializes the object with a random sprite SO from the SO list defined in SpriteHandler component.
/// </summary>
public class RandomInitialSprite : MonoBehaviour
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could probably include this as part of Sprite handler may be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done; please confirm changes to SpriteHandler look good.

@corp-0 corp-0 merged commit 651d58e into unitystation:develop Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants