Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly mobs update #5914

Merged
merged 13 commits into from
Feb 5, 2021
Merged

Friendly mobs update #5914

merged 13 commits into from
Feb 5, 2021

Conversation

corp-0
Copy link
Member

@corp-0 corp-0 commented Jan 28, 2021

Purpose:

  • Tweak chicken mood to streamline it
  • Add mob mood descriptions so people can roughly know what's the mood of a mob by examining it.
  • Milkable component to obtain milk from happy milkable mobs.
  • Feedable mob component so you can feed the mob with food in your hand.
  • Retaliate AI for mobs that only attack when attacked.

Notes:

I patched BodyPartBehavior so MaxDamage is the same as the MaxHealth from the LivingHealthBehavior class, otherwise as noted by @PerfectTangent mobs would never die.

Cows use the regular friendly AI so they look a little hyperactive.

Changelog:

CL: added examination interaction to get what a mob's mood.
CL: added new generic mob ai that only becomes hostile after being attacked.
CL: added milkable component to milk mobs based on their mood.
CL: added feedable component as a generic way to make mobs able to be fed by hand.
CL: fixed NRE when interacting with chickens with no item in hand.

@corp-0 corp-0 force-pushed the milky branch 3 times, most recently from 9143970 to 69d1abd Compare January 29, 2021 06:26
@github-actions github-actions bot added the Status: Merge Conflicts No one likes conflicts, solve them! label Jan 29, 2021
@corp-0 corp-0 removed the Status: Merge Conflicts No one likes conflicts, solve them! label Jan 29, 2021
@corp-0
Copy link
Member Author

corp-0 commented Jan 29, 2021

wait wtf, why is it adding old commits

@corp-0
Copy link
Member Author

corp-0 commented Jan 29, 2021

there we go

@corp-0 corp-0 marked this pull request as ready for review January 29, 2021 06:32
@NoooneyDude
Copy link
Contributor

Reference to discussion on milking mood behaviour: https://discord.com/channels/273774715741667329/273774715741667329/804632247649959966

@corp-0 corp-0 added the Status: DNM "Do Not Merge". Don't merge this Pull Request, as changes where requor further additions are needed. label Jan 29, 2021
@corp-0 corp-0 added Status: Awaiting Review for PRs that are awaiting reviews/rereviews and removed Status: DNM "Do Not Merge". Don't merge this Pull Request, as changes where requor further additions are needed. labels Feb 1, 2021
@corp-0
Copy link
Member Author

corp-0 commented Feb 1, 2021

Done requested changes by @NoooneyDude .

@github-actions github-actions bot added the Status: Merge Conflicts No one likes conflicts, solve them! label Feb 3, 2021
@corp-0 corp-0 removed the Status: Merge Conflicts No one likes conflicts, solve them! label Feb 4, 2021
Co-authored-by: NoooneyDude <noooneydude@gmail.com>
@corp-0
Copy link
Member Author

corp-0 commented Feb 5, 2021

Commited the suggestion

corp-0 and others added 2 commits February 5, 2021 04:01
Co-authored-by: NoooneyDude <noooneydude@gmail.com>
Co-authored-by: NoooneyDude <noooneydude@gmail.com>
@NoooneyDude NoooneyDude merged commit 1571252 into unitystation:develop Feb 5, 2021
@corp-0 corp-0 deleted the milky branch July 13, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Review for PRs that are awaiting reviews/rereviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants