Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clothing SOs to new SO script, update prefabs with ClothingV2 #6002

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

NoooneyDude
Copy link
Contributor

@NoooneyDude NoooneyDude commented Feb 12, 2021

  • New singular SO to serve sprite data for all clothing. Removes scripts responsible for the old SOs.
    This SO no longer has an "adjusted" section; these are now just represented by a new SO asset.
  • Updates ClothingV2 to reflect the change. Changing the current sprite data is now similar to how it would be done in SpriteHandler.
  • Updated all old SOs to the new version, including generating adjusted versions (identified by _adjusted) reference.
  • Updated all references in the ClothingV2 components to the new SOs, including adjusted SOs where relevant and available.
  • FlashLight and facehugger scripts have been updated to take advantage of these changes.
    hardhat headlamp

CL:Player lights now update sprite on player character where relevant (e.g. hardhat headlamps).

Tested with two clients on headless; no obvious issues.

@Bod9001
Copy link
Member

Bod9001 commented Feb 12, 2021

just noting does, Sprite handler handle the networking for variant change? when the character changes directions, since that's pretty "expensive" networking since you have to do it for every single sprite vs the one message saying character change direction

@corp-0
Copy link
Member

corp-0 commented Feb 12, 2021

can you do separate commits for the prefabs and .cs files? I literally can't find any script to review

@NoooneyDude
Copy link
Contributor Author

can you do separate commits for the prefabs and .cs files? I literally can't find any script to review

:excellent: :evil:

@corp-0
Copy link
Member

corp-0 commented Feb 12, 2021

devilish

@NoooneyDude
Copy link
Contributor Author

I've split into two commits.

just noting does, Sprite handler handle the networking for variant change? when the character changes directions, since that's pretty "expensive" networking since you have to do it for every single sprite vs the one message saying character change direction

I didn't change too much on the spritehandler side, just expose a method to allow changing sprite SOs and the way the spritehandler cache thing is populated in ClothingV2. You should be able to see the changes easier now - in first commit.

@Bod9001
Copy link
Member

Bod9001 commented Feb 12, 2021

ok cool

@corp-0
Copy link
Member

corp-0 commented Feb 12, 2021

mergegegege

@corp-0 corp-0 merged commit 2bba710 into unitystation:develop Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants