Lights Sparking When Broken #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatDan123
added
the
Status: Awaiting Review
corp-0
reviewed
Feb 18, 2021
Co-authored-by: Gilles <43683714+corp-0@users.noreply.github.com>
|
sparks emit light? |
|
yup |
|
awesome |
|
does this make the electrical storm random event cause the lights to spark upon shorting? |
|
probably if it breaks the lights |
|
neat |
|
Looks good to me |
|
hey, @ThatDan123, does this satisfy issue #2410? |
|
nah, but its close, the effect needs to be made into its own static function so can be called by any script. Wouldnt be too hard to change, but it currently doesnt fix that issue. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CL: Broken lights now spark occasionally, which can start fires.