-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Night vision goggles now have night vision. #6112
Conversation
UnityProject/Assets/Scripts/Clothing/Eyewear/NightVisionGoggles.cs
Outdated
Show resolved
Hide resolved
UnityProject/Assets/Scripts/Clothing/Eyewear/NightVisionGoggles.cs
Outdated
Show resolved
Hide resolved
Unity reports "NetworkConnection, TargetRPC, TargetRPCAttribute cannot be found". What did we miss when making the changes? |
UnityProject/Assets/Scripts/Clothing/Eyewear/NightVisionGoggles.cs
Outdated
Show resolved
Hide resolved
UnityProject/Assets/Scripts/Clothing/Eyewear/NightVisionGoggles.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: ThatDan123 <56727168+ThatDan123@users.noreply.github.com>
Co-Authored-By: ThatDan123 <56727168+ThatDan123@users.noreply.github.com>
Last I knew this is still wip, added DNM until it is tested and ready to merge. |
Like I said on discord, I'm waiting for Dan to fix connection problem. If he can't find a way to fix this then we'll revert back to 03ee9f1 and work on the And who knows? maybe the issue is from another thing that's not our problem and it will get fixed before tomorrow. |
Yeah, the label is just prevempting someone from accidentaly merging thinking it was ready. |
Im gonna be a bit busy over the next few days, so revert to the working commit for now. And put a note in the script that it'll need syncing to rejoinning clients at some point. |
Co-Authored-By: ThatDan123 <56727168+ThatDan123@users.noreply.github.com>
The revert has been tested and it works fine, I think we can finally have one last review and then merge this. |
Test if night vision works after relog. Also how good it works with shuttles? |
How do I test that in playmode inside the editor? and wdym? |
My bad, I forgot that you cant join as client in editor.
destroy all the light on evac shuttle and test if night vision works correct while shuttle is moving |
No issues as far as I can tell from my testing. I guess we can merge now. |
UnityProject/Assets/Scripts/Clothing/Eyewear/NightVisionGoggles.cs
Outdated
Show resolved
Hide resolved
UnityProject/Assets/Scripts/Clothing/Eyewear/NightVisionGoggles.cs
Outdated
Show resolved
Hide resolved
private Vector3 nightVisionVisibility; | ||
|
||
[SerializeField, Tooltip("The default minimal visibility size.")] | ||
private Vector3 defaultVisionVisibility; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future this should read directly what the creature has as default visibility, I think. So we have creatures than can see in the dark without goggles.
Purpose
Adds functionality to night vision goggles. They will now allow players to see a bit clearer in the dark.
Changelog:
CL: Created a Night Vision Goggle script that enables the night vision shader and makes player vision a bit clearer in the dark.
AdjustPlayerVisibility(Vector3 newSize)
function has been added to adjust the player's vision in the dark.