Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides player names and player jobs from the stats tab #6324

Merged
merged 2 commits into from
Apr 4, 2021

Conversation

MaxIsJoe
Copy link
Contributor

@MaxIsJoe MaxIsJoe commented Apr 2, 2021

Purpose

Title. solves #6091

Notes:

It's cleaner to just display all players inside that tab instead of creating an entire new window for it.

Changelog:

CL: Antags and character names will no longer be displayed inside of the stats tab.

Copy link
Contributor

@ThatDan123 ThatDan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont need to show player usernames at all now as they are shown in the player list.

Also you can remove the networking parts which send the names and jobs as they shouldnt be needed anymore

@github-actions github-actions bot added the UI label Apr 4, 2021
@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 4, 2021

Dont need to show player usernames at all now as they are shown in the player list.

Also you can remove the networking parts which send the names and jobs as they shouldnt be needed anymore

I've removed usernames from the stats tab as you requested, however removing the networking parts broke the game for me so I guess they're still needed somewhere. Either way PR is done, ready to merge.

@ThatDan123 ThatDan123 merged commit c5eceb7 into unitystation:develop Apr 4, 2021
@MaxIsJoe MaxIsJoe deleted the REVEALYOURSECRETS branch April 5, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants