Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Autolathe destruction bug #6352

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Conversation

Semuca
Copy link
Contributor

@Semuca Semuca commented Apr 11, 2021

Purpose

Fixes #6348. When the server hooks were being removed, Autolathes/Circuit Imprintors with no materialStorageLink would cause an error in the despawning process.

Changelog:

CL: Fixed Autolathes not being destroyed when not connected to a material silo or storage.

When the server hooks were being removed, Autolathes/Circuit Imprintors with no materialStorageLink would cause an error in the despawning process.
@corp-0
Copy link
Member

corp-0 commented Apr 11, 2021

why was materialStorageLink null though?

@corp-0
Copy link
Member

corp-0 commented Apr 11, 2021

CL: Added null check to Autolathe's materialStorageLink during destruction.

change this line to something that makes more sense for the final user, maybe something like "Fixed autolathes sometimes not despawning when destroyed".

@Semuca
Copy link
Contributor Author

Semuca commented Apr 11, 2021

why was materialStorageLink null though?

My bad, I'll clarify. materialStorageLink is from a recent update where lathes can have their own material silos or storages, separate from the lathe. With machines that are newly made, or just not connected to a seperate silo, they won't have a materialStorageLink by default. I've also updated the changelog, I didn't realise the changelog was directly sent to stationHub.

@corp-0
Copy link
Member

corp-0 commented Apr 11, 2021

wonderful, thank you very much

@corp-0 corp-0 requested a review from Aranclanos April 11, 2021 10:35
@Bod9001 Bod9001 merged commit f1b5b19 into unitystation:develop Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invincible Circuit Imprinter
3 participants