Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs with players buckled to pushable objects. #6370

Merged
merged 5 commits into from
Apr 15, 2021

Conversation

Semuca
Copy link
Contributor

@Semuca Semuca commented Apr 15, 2021

Purpose

Fixes #6344 and other bugs to do with objects that can buckle players and be pushed/pulled like:

  • Players ending up in their original position after unbuckling with an object like a rollerbed or chair with wheels.
  • Bloodsplats spawning in the wrong position when a player buckled to a pushable object is shot
  • Players having a rollerbed taken from under them still being buckled

Explanation:

This bug is caused by the player's position not changing when being buckled to a pushed object and instead staying at where they were originally buckled, which causes a lot of problems.

  • When being unbuckled from an object, they will go back to their original buckled position, appearing to other players like they've vanished.
  • When shot, the blood will spawn at this originally buckled position.
  • When the rollerbed is taken from underneath them, they won't be properly unbuckled because the game is looking for a player to unbuckle at the rollerbed's current position, when the player is actually at the originally buckled position.

Changelog:

CL: Fixed buckled players not behaving properly when attached to pushable objects

Semuca and others added 5 commits April 11, 2021 13:47
When the server hooks were being removed, Autolathes/Circuit Imprintors with no materialStorageLink would cause an error in the despawning process.
Players buckled to pushable objects will now move with them.
@Semuca
Copy link
Contributor Author

Semuca commented Apr 15, 2021

Sorry I don't know why all those other commits are there, only one has new changes.

@corp-0
Copy link
Member

corp-0 commented Apr 15, 2021

start working with a fresh new branch next time and prefer updating your branch by rebasing. Code looks good.

@corp-0 corp-0 merged commit 1b92abf into unitystation:develop Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roller Bed Patient Disappearing
2 participants