Body part slots v3

[Bod9001]

currently it's just to check what's been changed and fix any merge conflicts

Notes:

still need to do handcuffs

fixes #6066

CL: UI slots are now determined by what clothing and body parts you have

[PerfectTangent]

anxious sweating

[Bod9001]

to be fair got plenty of time, have to wait for a good build of 4119 before merging

[MaxIsJoe]

Needs documentation of all public and variables functions before merging.

[MaxIsJoe]

Also since this is a WIP, I suggest turning this PR into a draft.

[Bod9001]

"Needs documentation of all public and variables functions before merging."
which ones?

[MaxIsJoe]

After reading more I believe even some of the logic needs to be documented.
Here's the scripts that needs comments to explain what everything is doing and what it's use case :

• InteractableStorage (what does showAlert bool do? Why are we looping through all that?)
• Camera2DFollow (What is Instance and why does the xOffset use the UI for that?)
• GenerateSpriteSO (Terrible variable names, No explanation for what exactly it's doing)
• PlayerHealth (Hand checks can probably be simplified instead of doing two foreach checks,
• RespitorySystem (maskItemAtts means that the variable will always be a mask, renaming it to itemAtt or currentItemAtt would probably be better)
• ClothingItem (if statement logic needs to be in a {} or right next to the if to keep code clean and consistent.)
• BodyPartSlotsUI (No comments explaining anything, DIM and add are bad variable names.)
• RequestInventoryTransferMessage (Requires comments explaining new logic)
• UpdateHeadSetKeyMessage (What is best hand? Confusing for first time programmers who see this kind of function)
• Equipment (Needs comments on new logic, Hardcoded they pronoun, use the character's pronouns instead)
• ExaminePlayer (Needs some documentation about the variables functions are using and what's the functions use casses under a ///< summary > doc)
• ClothingSlots (What is relatedStorage? Remove and Addself require documentation)
• DynamicItemStorage (Requires documentation)
• PopulateSubInventory (Requires documentation, The character had a similar issue where this wasn't documented so I spent several days trying to make sense of some of your code when you called things "sub" without explaining what exactly it's doing.
• InventoryMoveType (pu bad variable name)
• PlayerSlotStoragePopulator, StoragePopulator, UI_DynamicItemSlot (Requires documentation)

One more note that should be applied to all of these
If possible, add namespaces to them when they don't exist.

[Bod9001]

will do, Just need to do handcuffs

[corp-0]

files changed: 226

MonkaS

[corp-0]

to be fair got plenty of time, have to wait for a good build of 4119 before merging

Yes, but the best way to avoid conflicts is by continually updating your branch so you catch fewer conflicts while they are added and solve them by actually reading the differences and not just overwritting everything other person might have done.

[NoooneyDude]

I'm a bit concerned with the fact that the code needs a bunch of foreaches now to achieve the same task as before.

There's a bunch more new files that aren't namespaced and some that have been denamespaced.

[NoooneyDude]

The changes are different between HumanLeftLeg and HumanRightLeg. Expected?

[Bod9001]

it's interesting because the values are the same as the base prefab so you can't override them in the left leg prefab

[ThatDan123]

Does this fix this: #6066 ?

Could you add it to the post if it does

[Bod9001]

"InteractableStorage (what does showAlert bool do? Why are we looping through all that?)"

checking all the hands to check if the object is in the hands,

"Camera2DFollow (What is Instance and why does the xOffset use the UI for that?)"
idk it's hardcoded value I had to change because it used hands before, not quite sure what it does

"GenerateSpriteSO "
yeah, These are all the random ass editor functions for setting up prefabs/scriptable objects up and stuff, I just used it to set Everything to have a default ID, because the default populated doesn't have a suit to put the ID in, and if you replace the suit the ID goes with the suit

[MaxIsJoe]

"InteractableStorage (what does showAlert bool do? Why are we looping through all that?)"

checking all the hands to check if the object is in the hands,

"Camera2DFollow (What is Instance and why does the xOffset use the UI for that?)"
idk it's hardcoded value I had to change because it used hands before, not quite sure what it does

"GenerateSpriteSO "
yeah, These are all the random ass editor functions for setting up prefabs/scriptable objects up and stuff, I just used it to set Everything to have a default ID, because the default populated doesn't have a suit to put the ID in, and if you replace the suit the ID goes with the suit

I asked if you can document these in the files themselves.

[Bod9001]

"PlayerHealth (Hand checks can probably be simplified instead of doing two foreach checks,"
can do tho GC,

" best hand"
idk what else to call it

"Equipment (Needs comments on new logic, Hardcoded they pronoun, use the character's pronouns instead)"
where is it hardcoded?

[Bod9001]

"ExaminePlayer (Needs some documentation about the variables functions are using and what's the functions use casses under a ///< summary > doc)"

seems to have already good documentation?