-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ChemMaster and CondiMaster Neo #6547
Merged
NoooneyDude
merged 13 commits into
unitystation:develop
from
pyrosshade:ChemMasterAndFriends
May 20, 2021
Merged
Add the ChemMaster and CondiMaster Neo #6547
NoooneyDude
merged 13 commits into
unitystation:develop
from
pyrosshade:ChemMasterAndFriends
May 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CL: Updates ChemMaster with functionality CL: Any ReagentContainer can be hand placed in the ChemMaster as a container. This will need tweaking for balance and sensibility CL: ChemMaster starts with two 50u Beakers for it's buffer CL: ChemMaster can create pills, bottles and patches filled from reagents in it's buffer CL: ChemMaster can transfer 1, 5, 10, all, or custom integer reagent amounts, as well as analyze a given reagent, giving a short description of the reagent CL: ChemMaster can create products with custom names (character limit 50) CL: Adds Condimaster Neo, effectively a service department reskin of the ChemMaster CL: Condimaster Neo creates condiment bottles and condiment packets instead of what ChemMaster creates CL: Changes sprite filtering of SquareButtonvs16x16.png to POINT filtering for more crisp and/or faithful rendering of the given buttons
Should hopefully clear testing
This reverts commit 5e75fc2.
ChemMaster Merge Conflict
NoooneyDude
reviewed
May 19, 2021
ChemMaster does not handle networking itself. Co-authored-by: NoooneyDude <noooneydude@gmail.com>
Codacy got two complaints |
both valid issues btw |
Have you built tested with headless and client? |
I'm testing it now. |
Works, a few little issues that can be fixed later. Thank you! I've posted the issues in Discord #chemistry channel. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Scene Changes
Any changes that affect scenes (e.g. lobby or maps)
System: Chemistry
Tasks related to chemistry role
System: Health
Tasks related to medical role
Type: Feature
This label covers feature requests, i.e. things that are not in the game, but might be good to have.
UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ChemMaster and CondiMaster Neo
Fulfills item 4 of #6281 bounty issue
Changelog:
CL: [Improvement] Updates ChemMaster with functionality
CL: [New] Any ReagentContainer can be hand placed in the ChemMaster as a container. This will need tweaking for balance and sensibility
CL: [New] ChemMaster starts with two 50u Beakers for it's buffer
CL: [New] ChemMaster can create pills, bottles and patches filled from reagents in it's buffer
CL: [New] ChemMaster can transfer 1, 5, 10, all, or custom integer reagent amounts, as well as analyze a given reagent, giving a short description of the reagent
CL: [New] ChemMaster can create products with custom names (character limit 50)
CL: [New] Adds Condimaster Neo, effectively a service department reskin of the ChemMaster
CL: [New] Condimaster Neo creates condiment bottles and condiment packets instead of what ChemMaster creates
CL: [Improvement] Changes sprite filtering of SquareButtonvs16x16.png to POINT filtering for more crisp and/or faithful rendering of the given buttons