Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ChemMaster and CondiMaster Neo #6547

Merged
merged 13 commits into from
May 20, 2021

Conversation

pyrosshade
Copy link
Contributor

@pyrosshade pyrosshade commented May 17, 2021

Add the ChemMaster and CondiMaster Neo
Fulfills item 4 of #6281 bounty issue

Changelog:

CL: [Improvement] Updates ChemMaster with functionality
CL: [New] Any ReagentContainer can be hand placed in the ChemMaster as a container. This will need tweaking for balance and sensibility
CL: [New] ChemMaster starts with two 50u Beakers for it's buffer
CL: [New] ChemMaster can create pills, bottles and patches filled from reagents in it's buffer
CL: [New] ChemMaster can transfer 1, 5, 10, all, or custom integer reagent amounts, as well as analyze a given reagent, giving a short description of the reagent
CL: [New] ChemMaster can create products with custom names (character limit 50)
CL: [New] Adds Condimaster Neo, effectively a service department reskin of the ChemMaster
CL: [New] Condimaster Neo creates condiment bottles and condiment packets instead of what ChemMaster creates
CL: [Improvement] Changes sprite filtering of SquareButtonvs16x16.png to POINT filtering for more crisp and/or faithful rendering of the given buttons

CL: Updates ChemMaster with functionality
CL: Any ReagentContainer can be hand placed in the ChemMaster as a container. This will need tweaking for balance and sensibility
CL: ChemMaster starts with two 50u Beakers for it's buffer
CL: ChemMaster can create pills, bottles and patches filled from reagents in it's buffer
CL: ChemMaster can transfer 1, 5, 10, all, or custom integer reagent amounts, as well as analyze a given reagent, giving a short description of the reagent
CL: ChemMaster can create products with custom names (character limit 50)
CL: Adds Condimaster Neo, effectively a service department reskin of the ChemMaster
CL: Condimaster Neo creates condiment bottles and condiment packets instead of what ChemMaster creates
CL: Changes sprite filtering of SquareButtonvs16x16.png to POINT filtering for more crisp and/or faithful rendering of the given buttons
@github-actions github-actions bot added Scene Changes Any changes that affect scenes (e.g. lobby or maps) UI labels May 17, 2021
@ThatDan123 ThatDan123 added Status: Awaiting Review for PRs that are awaiting reviews/rereviews Status: Awaiting Testing for PRs that that should be tested before merging labels May 17, 2021
@NoooneyDude NoooneyDude added the Status: On Hold for PRs or issues that are on hold (during a code freeze, for example) label May 18, 2021
Should hopefully clear testing
@github-actions github-actions bot added the Status: Merge Conflicts No one likes conflicts, solve them! label May 18, 2021
@NoooneyDude NoooneyDude removed Status: Merge Conflicts No one likes conflicts, solve them! Status: On Hold for PRs or issues that are on hold (during a code freeze, for example) labels May 18, 2021
pyrosshade and others added 2 commits May 19, 2021 05:21
ChemMaster does not handle networking itself.

Co-authored-by: NoooneyDude <noooneydude@gmail.com>
@ThatDan123
Copy link
Contributor

Codacy got two complaints

@corp-0
Copy link
Member

corp-0 commented May 19, 2021

both valid issues btw

@ThatDan123
Copy link
Contributor

Have you built tested with headless and client?

@NoooneyDude
Copy link
Contributor

I'm testing it now.

@NoooneyDude
Copy link
Contributor

NoooneyDude commented May 20, 2021

Works, a few little issues that can be fixed later. Thank you!

I've posted the issues in Discord #chemistry channel.

@NoooneyDude NoooneyDude removed the Status: Awaiting Testing for PRs that that should be tested before merging label May 20, 2021
@NoooneyDude NoooneyDude merged commit f80814a into unitystation:develop May 20, 2021
@PerfectTangent PerfectTangent added the System: Chemistry Tasks related to chemistry role label May 22, 2021
@PerfectTangent PerfectTangent added System: Health Tasks related to medical role Type: Feature This label covers feature requests, i.e. things that are not in the game, but might be good to have. labels May 22, 2021
@PerfectTangent PerfectTangent removed the Status: Awaiting Review for PRs that are awaiting reviews/rereviews label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scene Changes Any changes that affect scenes (e.g. lobby or maps) System: Chemistry Tasks related to chemistry role System: Health Tasks related to medical role Type: Feature This label covers feature requests, i.e. things that are not in the game, but might be good to have. UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants