Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds in bleeding for dismembered parts #6625

Merged
merged 17 commits into from
Jun 6, 2021
Merged

Conversation

MaxIsJoe
Copy link
Contributor

@MaxIsJoe MaxIsJoe commented May 27, 2021

Purpose

Part of #6270

Characters will now bleed when they lose a limb, re-adjusted dismemberment chance values for each race so some races would be more fragile than others and added some missing documentation.

Blood Loss

Players who lose a limb have about 5-6 minutes to go to a doctor before they say goodbye to life due to blood loss, this time gets shorter with each dismembered limb and with the addition of Disemboweling in the next few PRs, this can drastically change to seconds as your body turns into a fountain of blood.
Right now all races share the same blood loss values, but later each race will lose more or less blood depending on how fragile they are.

Lizard stronk, Moth weak spit

Moths have the highest chance of dismemberment on the highest severe damage levels, nearly 90%!
Lizards on the other hand have a 70% chance to lose their limb on highest damage levels.
Humans and Catpeople almost share the same values, but the difference between them is that catpeople are more likely to lose their heads and torso compared to other humans. (87% for felines, 85% for humans)

If you don't want to lose your limb, start wearing armor!
Though armor values are still lacking on everything soooo, wait until next PRs.

Notes:

Currently to stop bleeding I've made Brusie Packs have the ability to stop bleeding temporarily until we discuss how we should approach limb loss bleed healing.

Changelog:

CL: [New] - Characters will now start bleeding when losing a limb.
CL: [Improvement] - Races no longer share the same dismemberment chance values.
CL: [Fix] - Fixed an error that would prevent damage to spread to all limbs by bombs.

@MaxIsJoe
Copy link
Contributor Author

Alright I think the code quality part is settled, time to merge.

@corp-0 corp-0 added Status: Awaiting Review for PRs that are awaiting reviews/rereviews Status: Awaiting Testing for PRs that that should be tested before merging labels May 28, 2021
@corp-0 corp-0 added Status: Awaiting Changes Something about this PR should be / was requested to be changed before merging Status: Awaiting Testing for PRs that that should be tested before merging and removed Status: Awaiting Review for PRs that are awaiting reviews/rereviews Status: Awaiting Testing for PRs that that should be tested before merging Status: Awaiting Changes Something about this PR should be / was requested to be changed before merging labels Jun 2, 2021
@corp-0
Copy link
Member

corp-0 commented Jun 4, 2021

Tested on server - client environment. Server spawned a synd bomb and client exploded it on their feet. The enumeration error is gone, but I did experience a freeze before seeing the result of the explosion.

@corp-0
Copy link
Member

corp-0 commented Jun 4, 2021

can someone else please try reproduce my experience?

@Bod9001
Copy link
Member

Bod9001 commented Jun 5, 2021

with a quick test was good for me

@jamessimo
Copy link
Contributor

Tested and work for me, cant speak towards the loop methods however.

@github-actions github-actions bot added the Status: Merge Conflicts No one likes conflicts, solve them! label Jun 6, 2021
@corp-0
Copy link
Member

corp-0 commented Jun 6, 2021

Are you conflicting with your other Pr that got merged?

@corp-0 corp-0 removed the Status: Awaiting Testing for PRs that that should be tested before merging label Jun 6, 2021
@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Jun 6, 2021

Are you conflicting with your other Pr that got merged?

I excepted for this PR and disembowling to conflict at some point when one of them gets merged, but body tint? that's an odd on.

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Jun 6, 2021

Merge conflicts solved.

@corp-0 corp-0 merged commit 38372c9 into unitystation:develop Jun 6, 2021
@corp-0 corp-0 removed the Status: Merge Conflicts No one likes conflicts, solve them! label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants