Adds in burn damage, Ashing and a small upgrade to advanced health scanners. #6800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corp-0
reviewed
Jun 15, 2021
corp-0
reviewed
Jun 15, 2021
ThatDan123
reviewed
Jun 15, 2021
UnityProject/Assets/Scripts/HealthV2/Living/Damage/BodyPartDamage.cs
Outdated
Show resolved
Hide resolved
UnityProject/Assets/Scripts/HealthV2/Living/Damage/BodyPartDamage.cs
Outdated
Show resolved
Hide resolved
UnityProject/Assets/Scripts/HealthV2/Living/Damage/BodyPartDamage.cs
Outdated
Show resolved
Hide resolved
…ron, Salvia Garcia. Cover by Jose Lopez. Meet Greg Pincus -- the planet's brand-spanking-newest Superhero. One small problem: Greg is neither super, nor particularly heroic. But, he sure enjoys the perks that come with the job. Can Greg survive in a celebrity-obsessed world that wrongly believes he's indestructible? Jeff Kline (Transformers: Prime, G.I. Joe: Renegades) explores this comedic take on a reluctant hero, and contemplates what is required to be considered 'special' in a world where fame can come and go faster than a speeding bullet. Cover price $3.99.
Bod9001
reviewed
Jun 16, 2021
|
The descriptions thing is cool but it is adding a lot of strings. Maybe it would be worth to try port it to use a StringBuilder |
Will look into it in the next PR while I fix surgery since I might add more strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
part of #6270 and #6272
Adds in the ability to deep fry your fellow crewmate's bodies until they're extra crisp. Body Parts can suffer from burn damage and when they're charred they have the ability to turn into ash. (Any items inside of these body parts that are marked with "CannotBeAshed" will not be destroyed and will simply drop on the ground.)
Advanced health scanners will now give you a detailed report on a body part's condition and what's inside of it.
Notes:
Like usual, additions and changes are gradual and are contained in small PRs so players can test them quickly on staging.
While I wished that I had fixed surgery along side this PR, it's still going to wait a bit and will be added alongside another PR that tackles healing and infections for traumatic wounds.
This PR also comes with some small documentation for some things.
Changelog:
CL: [New] - Players with burnt bodies will now visually appear burnt.
CL: [New] - Ashing has been added for body parts.
CL: [New] - Advanced health scanners have the ability now to give a detailed report on a body part when Alt-Clicking on the player you wish to diagnose.
CL: [Improvement] - Items like the Nuke Disk cannot be destroyed during Inventory drops or deletions.
CL: [Fix] - Fixes an error where body parts attempt to bleed out while they're no longer attached to a body.