Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AP bullet prefabs, placeholder disclaimers to uplink, small rebalance to guns and armor. #6821

Merged

Conversation

PerfectTangent
Copy link
Contributor

@PerfectTangent PerfectTangent commented Jun 19, 2021

Purpose

This PR does a few things. First, It adds AP bullet prefabs so that the AP bullet magazines available in the TC uplink actually do what they are advertised to do. Yay! Second, it adds a disclaimer to the currently unimplemented options in the traitor uplink, letting players know that they are just placeholders. Third, it removes some discrepancies seen amongst the existing AP values as well as in a couple armor sets.

Also, it rebalances some of the damage values of certain catridges to be more in line with modern /tg/, which has nerfed some of the traitor weapons, most notably, the SAW was reduced from 45 damage to 40 damage. I took it a step further and nerfed the .357 revolver slightly as well, which I've always thought was a bit ludicrously powerful for not even being a weapon that was particularly hard to acquire.

Lastly, this PR rebalances all armor that provides 100 bomb protection to instead provide 95 bomb protection. This will improve the game's balance when it comes to the cheesy and exploitative grenade tricks people have been pulling. It can still be done with most explosives, but now there's at least a cost for doing it.

Notes:

  • Armor Penetration values added for all the AP ammo magazines. Since our implementation is different than /tg/, I went with a baseline of a 50% armor reduction for all of them. It's a significant reduction and it's predictable; a clever player can easily reverse engineer their damage potential if they know what armor their target is wearing. That's useful information to know. The migraine's standard ammunition is inherently armor piercing, and comes with 50% AP as well. The penetrator round has 80% AP, but that's just temporary because it's intended function doesn't exist yet.
  • rebalanced some of the AP values added on other guns previously. Many used the /tg/ values, which functions differently.
  • {PLACEHOLDER] has been added to all unfinished and placeholder items in the syndicate uplink. Closes The placeholder items in the uplink should be removed or marked as placeholder #6811.
  • the buzzsaw's damage has been reduced from 45 to 40 damage
  • the .357 catridge has been reduced from 60 to 50 damage.
  • the X ray rifle has had it's attack type changed from laser to radiation to reflect /tg/.
  • MKIII SWAT suit, bomb suits, and the prototype hardsuit have had their bomb resistance reduced to 95 so they aren't immune to bomb damage.
  • the PRT and inquisitor hardsuits have gained 30 magic protection to mirror their helmets.
  • fixed the medical doctor's jumpsuit from having a 100% dismemberment resistance (probably accidentally left over from Max's testing during implementation)
  • made the chemist jumpskirt mirror the fire and acid armor values of the chemist jumpsuit (jumpskirts probably should be variants of their jumpsuit counterparts).
  • also added 10 melee protection to the clown suit in the chest. This is just a little experiment. I think it could be good for the clown. It gives them a touch more flexibility to push the limit with their jokes and makes them a bit more of a punching bag, leading to a good time all around. If it goes over well, I might even bump it to 20 melee protection in a future PR.

All of these changes are pretty small, but if anyone has any thoughts they'd like to share about the direction this PR goes in, feel free to bring them up.

Changelog:

CL: [New] the Armor Piercing ammunition in the syndicate uplink now pierces armor. All AP bullets reduce the effectiveness of armor by 50%.
CL: [Balance] damage of the 7.12 buzzsaw LMG nerfed from 45 to 40.
CL: [Balance] damage of the .357 revolvers nerfed from 60 to 50.
CL: [Balance] PRT and inquisitor armor have gained 30 magic protection.
CL: [Balance] the clown suit has gained 10 melee armor. Call it stuffing.
CL: [Balance] MKIII SWAT armor, the prototype hardsuit, and bombsuits have had their bomb armor nerfed from 100 to 95.
CL: [Fix] Fixed discrepancies with the protection values of the chemist jumpskirt and medical doctor jumpsuit.

@PerfectTangent PerfectTangent added the Type: Balance related to game balance label Jun 19, 2021
@PerfectTangent PerfectTangent changed the title Adds AP bullet prefabs, adds placeholder disclaimers to uplink, small rebalances to guns and armor. Adds AP bullet prefabs, adds placeholder disclaimers to uplink, small rebalance to guns and armor. Jun 19, 2021
@PerfectTangent PerfectTangent changed the title Adds AP bullet prefabs, adds placeholder disclaimers to uplink, small rebalance to guns and armor. Adds AP bullet prefabs, placeholder disclaimers to uplink, small rebalance to guns and armor. Jun 19, 2021
@pyrosshade
Copy link
Contributor

image

i believe you run the test locally and then commit these

@PerfectTangent
Copy link
Contributor Author

yeah, it's just an issue of not commiting it. ez fix.

@corp-0 corp-0 merged commit d26e13b into unitystation:develop Jun 19, 2021
@PerfectTangent PerfectTangent deleted the uplink-placeholders-and-AP-ammo branch June 20, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Balance related to game balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The placeholder items in the uplink should be removed or marked as placeholder
3 participants