Add transaction info to link #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The coverage is still acting weirdly, please do not mind it. See #69. |
perrin4869
reviewed
Oct 19, 2021
| @@ -117,6 +121,7 @@ export interface ConfigurationItem { | |||
| securityConfiguration: SecurityConfiguration; | |||
| subscriptionConfiguration: SubscriptionsConfiguration; | |||
| userTransactionsConfiguration?: UserTransactionsConfiguration; | |||
| widgetConfiguration?: WidgetConfiguration | null; | |||
There was a problem hiding this comment.
sorry for the confusion, but I went with checkoutConfiguration as the name here!
| @@ -95,6 +95,10 @@ export interface DescriptorProvidedConfiguration { | |||
| name: string; | |||
| phoneNumber: string; | |||
| } | |||
| export interface WidgetConfiguration { | |||
| ecEmail?: { enabled?: boolean | null } | null; | |||
There was a problem hiding this comment.
I think none of these is nullable or optional
There was a problem hiding this comment.
Thanks a lot 🙂
|
@perrin4869 Thanks for catching the issues 🙂 I was trying with the ticket values. |
perrin4869
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to https://github.com/univapaycast/services-typescript/pull/800