Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove filter logic for SendData, refactor getHeaders #53

Merged
merged 4 commits into from
Aug 26, 2020
Merged

remove filter logic for SendData, refactor getHeaders #53

merged 4 commits into from
Aug 26, 2020

Conversation

laxa88
Copy link
Contributor

@laxa88 laxa88 commented Aug 25, 2020

@laxa88 laxa88 added the Enhancement New feature or request label Aug 25, 2020
@coveralls
Copy link

coveralls commented Aug 25, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling 282e298 on fix/laxa88/auth into 54bf2fd on master.

perrin4869
perrin4869 reviewed Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@perrin4869 perrin4869 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if the new AuthParam keys should be placed under the deprecated comment!

src/api/RestAPI.ts Outdated Show resolved Hide resolved
@perrin4869
Copy link
Collaborator

want to approve but can't find a button ><;; lol

phieronymus
phieronymus approved these changes Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@phieronymus phieronymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a lesser comment in case it was not on purpose 🙂 Otherwise approved!

src/api/RestAPI.ts Outdated Show resolved Hide resolved
@perrin4869 perrin4869 merged commit 5fbdfa2 into master Aug 26, 2020
@phieronymus phieronymus deleted the fix/laxa88/auth branch October 7, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrin4869 perrin4869 perrin4869 left review comments

@phieronymus phieronymus phieronymus approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laxa88 @coveralls @perrin4869 @phieronymus