Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email and hidePrefilledEmail to ECFormLinkItem #846

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

YusukeFukushima
Copy link
Collaborator

@YusukeFukushima YusukeFukushima commented Jul 19, 2023

@YusukeFukushima YusukeFukushima added the Enhancement New feature or request label Jul 19, 2023
@coveralls
Copy link

coveralls commented Jul 19, 2023

Coverage Status

coverage: 99.571% (+0.1%) from 99.462% when pulling 0b88251 on feature/yfukushima/merchant-3314/prefilled-email into f3439f6 on master.

@@ -31,6 +31,8 @@ export type ECFormLinkItem = {
tokenType: TransactionTokenType;
tokenOnly: boolean;
hideCvv?: boolean;
email?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have that. We will have to rely on the link metadata for this parameter. We only need to add hidePrefilledEmail 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed 👍 Please check again 🙇

Copy link
Collaborator

@phieronymus phieronymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phieronymus phieronymus merged commit e271dd0 into master Jul 20, 2023
5 checks passed
@phieronymus phieronymus deleted the feature/yfukushima/merchant-3314/prefilled-email branch July 20, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants